netdev - Re: pull-request: bpf-next 2023-09-16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+fX-_Y4efStz5_898hnMZrQz2x0YuQ_MCiYwG73g12PA@mail.gmail.com>
Date: Tue, 19 Sep 2023 02:09:55 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Eric Dumazet <edumazet@...gle.com>, Kumar Kartikeya Dwivedi <memxor@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Network Development <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, 
	Kernel Team <kernel-team@...com>
Subject: Re: pull-request: bpf-next 2023-09-16

On Mon, Sep 18, 2023 at 6:54 AM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
> > > >
> > >
> > > This might have been raised already, but bpf on x86 now depends on
> > > CONFIG_UNWINDER_ORC ?
> > >
> > > $ grep CONFIG_UNWINDER_ORC .config
> > > # CONFIG_UNWINDER_ORC is not set
> > >
> > > $ make ...
> > > arch/x86/net/bpf_jit_comp.c:3022:58: error: no member named 'sp' in
> > > 'struct unwind_state'
> > >                 if (!addr || !consume_fn(cookie, (u64)addr,
> > > (u64)state.sp, (u64)state.bp))
> > >                                                                  ~~~~~ ^
> > > 1 error generated.
> >
> > Kumar,
> > can probably explain better,
> > but no the bpf as whole doesn't depend.
> > One feature needs either ORC or frame unwinder.
> > It won't work with unwinder_guess.
> > The build error is a separate issue.
> > It hasn't been reported before.
>
> I see the error with CONFIG_UNWINDER_FRAME_POINTER.
> That's unexpected.
> Kumar,
> looks like this config path wasn't tested.
>
> Eric, Paolo, Dave, Kuba,
> please ignore this PR.
> We need to fix this first.

Sorry, wifi is slow here. I didn't notice that it got merged
and pw-bot didn't notice it either (no emails).
We'll send another bpf-next PR with fixes right away.
Sorry about the build breakage.