netdev - Re: [PATCH net-next 1/3] net: libwx: support hardware statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad8d1b2aaea245f2c21548b7ee485fbd8c57b0fb.camel@redhat.com>
Date: Tue, 19 Sep 2023 12:08:15 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, andrew@...n.ch
Cc: mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next 1/3] net: libwx: support hardware statistics

On Mon, 2023-09-18 at 15:21 +0800, Jiawen Wu wrote:
> +void wx_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
> +{
> +	struct wx *wx = netdev_priv(netdev);
> +	char *p = (char *)data;
> +	int i;
> +
> +	switch (stringset) {
> +	case ETH_SS_TEST:
> +		memcpy(data, *wx_gstrings_test,
> +		       WX_TEST_LEN * ETH_GSTRING_LEN);

It looks like fortify source/clang is not happy about the above line
I'm not sure of the exact curprit as the warning output lacks a
specific indication.

In any case the above syntax is a bit confusing, '*wx_gstrings_test' vs
'wx_gstrings_test' and  WX_TEST_LEN not using ARRAY_SIZE.

Please clean-up the above and try to avoid the mentioned warning.

Cheers,

Paolo