netdev - Re: [PATCH net-next] Improving `ip link show` output in iproute2 for PF/VF association

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230920082353.6a6cefcb@hermes.local>
Date: Wed, 20 Sep 2023 08:23:53 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: skakishi <skakishi@...oo-corp.jp>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] Improving `ip link show` output in iproute2
 for PF/VF association

On Wed, 20 Sep 2023 14:28:27 +0900
skakishi <skakishi@...oo-corp.jp> wrote:

> Hello all,
> 
> The current version of iproute2 does not display clear associations between
> Physical Functions (PFs) and Virtual Functions (VFs). To address this limitation,
> I've added the following enhancement.
> 
> Proposed Changes
> When the 'detail' option is enabled, the command will display additional details,
> including VF IDs and their respective names.
> 
> For non-SR-IOV legacy mode:
> $ ip link show -d
> ...
> 1: enp6s0f0np0: ...
> vf 0 link/ether ... name enp6s0f1v0
> vf 1 link/ether ... name enp6s0f1v1
> ...
> 
> For SR-IOV switchdev mode (including VF representor information):
> $ ip link show -d
> ...
> 1: enp6s0f0np0: ...
> vf 0 link/ether ... name enp6s0f0v0, representor enp6s0f0npf0vf0
> vf 1 link/ether ... name enp6s0f0v1, representor enp6s0f0npf0vf1
> ...
> 
> Technical Details
> I've taken the additional data from sysfs.
> 
> Current Work Status
> I am actively working on implementing this extension.
> 
> Request for Feedback
> Do you find this feature useful?
> Do you think getting data from sysfs is an appropriate approach? Are there any
> alternative methods you would recommend?
> 
> Best regards,

I prefer that functionality in iproute2 comes from netlink.
The kernel may need a change to put the vfinfo in the current netlink data.
Sysfs becomes less likely to work in cases where containers or other security parameters
are involved.