netdev - Re: mv88e6xxx: Timeout waiting for EEPROM done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33eed988-f7cd-4e65-8047-0fe128a386e1@lunn.ch>
Date: Wed, 20 Sep 2023 18:46:03 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Fabio Estevam <festevam@...il.com>
Cc: Vladimir Oltean <olteanv@...il.com>, l00g33k@...il.com,
	netdev <netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>,
	sashal@...nel.org
Subject: Re: mv88e6xxx: Timeout waiting for EEPROM done

> If this works for Alfred, I can submit it as a proper patch.

Hi Fabio

Thanks for testing. This is the correct concept. But there is one
detail to take care of.

Not all generations of switches support accessing the EEPROM. So
mv88e6xxx_g2_eeprom_wait() cannot be used unconditionally. You need to
test chip->info->ops->get_eeprom and if it is not NULL, then you know
it is supported. If it is NULL, then all i can suggest is we do
nothing and hope for the best with the reset.

For stable, such a test is sufficient. For net-next, we might consider
adding a .wait_eeprom to struct mv88e6xxx_ops.

       Andrew