netdev - Re: [PATCH net-next 54/54] net: ethernet: xscale: Convert to platform remove callback returning void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3a5th1dtu.fsf@t19.piap.pl>
Date: Wed, 20 Sep 2023 09:52:29 +0200
From: Krzysztof Hałasa <khalasa@...p.pl>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 Linus Walleij
 <linusw@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>,  Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo Abeni
 <pabeni@...hat.com>,  netdev@...r.kernel.org,  kernel@...gutronix.de
Subject: Re: [PATCH net-next 54/54] net: ethernet: xscale: Convert to
 platform remove callback returning void

Hello Uwe, Linus,

Uwe Kleine-König <u.kleine-koenig@...gutronix.de> writes:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new() which already returns void. Eventually after all drivers
> are converted, .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

This makes perfect sense of course.

BTW, Linus, this is a separate entry in MAINTAINERS (INTEL IXP4XX QMGR,
NPE, ETHERNET and HSS SUPPORT). Perhaps you'd want it as well?
While I still have access to IXP425 and IXP435 hw, I haven't (literally)
touched them in years, so I guess there is very little reason (or rather
none at all) for me to linger as a maintainer of anything related to
IPX4xx anymore. If you wish, I can prepare a MAINTAINERS patch, or
something.

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Acked-by: Krzysztof Hałasa <khalasa@...p.pl>

> ---
>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

-- 
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa