netdev - Re: [PATCH net-next 06/18] net/smc: extend GID to 128bits for virtual ISM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 20 Sep 2023 11:00:59 +0200
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Wen Gu <guwen@...ux.alibaba.com>, kernel test robot <lkp@...el.com>,
        kgraul@...ux.ibm.com, wenjia@...ux.ibm.com, jaka@...ux.ibm.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, alibuda@...ux.alibaba.com,
        tonylu@...ux.alibaba.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 06/18] net/smc: extend GID to 128bits for
 virtual ISM device

On Wed, 2023-09-20 at 16:11 +0800, Wen Gu wrote:
> 
> On 2023/9/20 15:02, kernel test robot wrote:
> > Hi Wen,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on net-next/main]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Wen-Gu/net-smc-decouple-ism_dev-from-SMC-D-device-dump/20230920-010019
> > base:   net-next/main
> > patch link:    https://lore.kernel.org/r/1695134522-126655-7-git-send-email-guwen%40linux.alibaba.com
> > patch subject: [PATCH net-next 06/18] net/smc: extend GID to 128bits for virtual ISM device
> > config: s390-defconfig (https://download.01.org/0day-ci/archive/20230920/202309201408.95QRxHEl-lkp@intel.com/config)
> > compiler: s390-linux-gcc (GCC) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230920/202309201408.95QRxHEl-lkp@intel.com/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > > Reported-by: kernel test robot <lkp@...el.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202309201408.95QRxHEl-lkp@intel.com/
> > 
> > All errors (new ones prefixed by >>):
> > 
> >     net/smc/smc_ism.c: In function 'smc_ism_signal_shutdown':
> > > > net/smc/smc_ism.c:539:57: error: incompatible type for argument 2 of 'lgr-><U72f8>.<U7260>.smcd->ops->signal_event'
> >       539 |         rc = lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
> >           |                                                      ~~~^~~~~~~~~~
> >           |                                                         |
> >           |                                                         struct smcd_gid
> >     net/smc/smc_ism.c:539:57: note: expected 'u64' {aka 'long long unsigned int'} but argument is of type 'struct smcd_gid'
> > 
> > 
> > vim +539 net/smc/smc_ism.c
> > 
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  526
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  527  int smc_ism_signal_shutdown(struct smc_link_group *lgr)
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  528  {
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  529  	int rc = 0;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  530  #if IS_ENABLED(CONFIG_ISM)
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  531  	union smcd_sw_event_info ev_info;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  532
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  533  	if (lgr->peer_shutdown)
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  534  		return 0;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  535
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  536  	memcpy(ev_info.uid, lgr->id, SMC_LGR_ID_SIZE);
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  537  	ev_info.vlan_id = lgr->vlan_id;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  538  	ev_info.code = ISM_EVENT_REQUEST;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23 @539  	rc = lgr->smcd->ops->signal_event(lgr->smcd, lgr->peer_gid,
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  540  					  ISM_EVENT_REQUEST_IR,
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  541  					  ISM_EVENT_CODE_SHUTDOWN,
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  542  					  ev_info.info);
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  543  #endif
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  544  	return rc;
> > 820f21009f1bc7a Stefan Raspl 2023-01-23  545  }
> > 201091ebb2a161a Ursula Braun 2020-09-26  546
> > 
> 
> I do not have a local compilation environment for s390 (IBM Z) architecture. But I think
> it can be fixed by the following patch.

With these kernel test robot mails the bot provides
instructions for reproducing with a cross toolchain from the 0day
project. See the line starting with "reproduce (this is a W=1 build):"
i.e. in this particular case it links the URL:
https://download.01.org/0day-ci/archive/20230920/202309201408.95QRxHEl-lkp@intel.com/reproduce