netdev - RE: [PATCH net-next] net: ethernet: xilinx: Drop kernel doc comment about return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MN0PR12MB5953F2D5B9B6CECB25CD4121B7F8A@MN0PR12MB5953.namprd12.prod.outlook.com>
Date: Thu, 21 Sep 2023 06:41:38 +0000
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@....com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	"David S . Miller" <davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: RE: [PATCH net-next] net: ethernet: xilinx: Drop kernel doc comment
 about return value

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Sent: Thursday, September 21, 2023 12:05 PM
> To: David S . Miller <davem@...emloft.net>
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@....com>;
> netdev@...r.kernel.org; kernel@...gutronix.de; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>
> Subject: [PATCH net-next] net: ethernet: xilinx: Drop kernel doc comment
> about return value
> 
> During review of the patch that became 2e0ec0afa902 ("net: ethernet:
> xilinx: Convert to platform remove callback returning void") in
> net-next, Radhey Shyam Pandey pointed out that the change makes the
> documentation about the return value obsolete. The patch was applied
> without addressing this feedback, so here comes a fix in a separate
> patch.
> 
> Fixes: 2e0ec0afa902 ("net: ethernet: xilinx: Convert to platform remove
> callback returning void")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@....com>

Thanks!
> ---
> Hello,
> 
> I don't know if you keep net-next/main stable. If you're relaxed here,
> feel free to squash this patch into the original commit.
> 
> Best regards
> Uwe
> 
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 32a502e7318b..765aa516aada 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -1180,8 +1180,6 @@ static int xemaclite_of_probe(struct
> platform_device *ofdev)
>   * This function is called if a device is physically removed from the system or
>   * if the driver module is being unloaded. It frees any resources allocated to
>   * the device.
> - *
> - * Return:	0, always.
>   */
>  static void xemaclite_of_remove(struct platform_device *of_dev)
>  {
> 
> base-commit: 940fcc189c51032dd0282cbee4497542c982ac59
> --
> 2.40.1