netdev - Re: [PATCH v2] net: ipv4,ipv6: fix IPSTATS_MIB_OUTFORWDATAGRAMS increment after fragment check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba51c689c1954219c2cea904dc71eb1f0a721c29.camel@redhat.com>
Date: Thu, 21 Sep 2023 09:46:16 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Heng Guo <heng.guo@...driver.com>, davem@...emloft.net,
 sahern@...nel.org,  edumazet@...gle.com, kuba@...nel.org
Cc: netdev@...r.kernel.org, filip.pudak@...driver.com
Subject: Re: [PATCH v2] net: ipv4,ipv6: fix IPSTATS_MIB_OUTFORWDATAGRAMS
 increment after fragment check

On Tue, 2023-09-19 at 17:38 +0800, Heng Guo wrote:
> diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c
> index 66fac1216d46..acba24fc000f 100644
> --- a/net/ipv4/ip_forward.c
> +++ b/net/ipv4/ip_forward.c
> @@ -66,8 +66,6 @@ static int ip_forward_finish(struct net *net, struct sock *sk, struct sk_buff *s
>  {
>  	struct ip_options *opt	= &(IPCB(skb)->opt);
>  
> -	__IP_INC_STATS(net, IPSTATS_MIB_OUTFORWDATAGRAMS);
> -
>  #ifdef CONFIG_NET_SWITCHDEV
>  	if (skb->offload_l3_fwd_mark) {
>  		consume_skb(skb);
> @@ -130,6 +128,8 @@ int ip_forward(struct sk_buff *skb)
>  	if (opt->is_strictroute && rt->rt_uses_gateway)
>  		goto sr_failed;
>  
> +        __IP_INC_STATS(net, IPSTATS_MIB_OUTFORWDATAGRAMS);

The above is white-space damaged - uses spaces instead of tab.

Please fix it.

Also IMHO this is net-next material, please specify accordingly the
target tree into the subj line.

Thanks,

Paolo