[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <13c19c01-65ee-44ae-e11a-d3b108c5a97c@intel.com>
Date: Thu, 21 Sep 2023 10:52:48 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Michal Michalik <michal.michalik@...el.com>, <netdev@...r.kernel.org>,
Richard Cochran <richardcochran@...il.com>, <linux-kernel@...r.kernel.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, Tony Nguyen
<anthony.l.nguyen@...el.com>, <intel-wired-lan@...ts.osuosl.org>, "Milena
Olech" <milena.olech@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 0/3] net/intel: fix link-time
undefined reference errors
On 9/20/23 20:07, Alexander Lobakin wrote:
> Recently, several link-time issues were spotted in the ethernet/intel/
> folder thanks to Kbuild bots and linux-next.
> The fixes are pretty straightforward, just some stubs and CONFIG_*
> guards, so resolve all of them in one shot and unbreak randconfig
> builds.
>
> Alexander Lobakin (3):
> ice: fix undefined references to ice_is_*() when
> !CONFIG_PTP_1588_CLOCK
> ice: fix undefined references from DPLL code when
> !CONFIG_PTP_1588_CLOCK
> idpf: fix undefined reference to tcp_gro_complete() when !CONFIG_INET
>
> drivers/net/ethernet/intel/ice/Makefile | 5 ++---
> drivers/net/ethernet/intel/ice/ice_main.c | 8 ++++---
> drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 25 ++++++++++++++++++++-
> drivers/net/ethernet/intel/idpf/idpf_txrx.c | 3 +++
> 4 files changed, 34 insertions(+), 7 deletions(-)
>
> ---
> Directly to netdev/net-next, build bots are not happy and the next
> linux-next is approaching :s
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
I like the `if (IS_ENABLED(xxx))` approach more than stubs :)
Powered by blists - more mailing lists