[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7225922434776cb1a37642e9c828b821da536270.camel@sipsolutions.net>
Date: Thu, 21 Sep 2023 19:54:41 +0200
From: Johannes Berg <johannes@...solutions.net>
To: linux-kernel@...r.kernel.org
Cc: linux-trace-kernel@...r.kernel.org, netdev@...r.kernel.org,
linux-wireless@...r.kernel.org
Subject: Re: [RFC PATCH 3/4] net: drop_monitor: use drop_reason_lookup()
On Thu, 2023-09-21 at 10:51 +0200, Johannes Berg wrote:
>
> - if (!list ||
> - subsys_reason >= list->n_reasons ||
> - !list->reasons[subsys_reason] ||
> - strlen(list->reasons[subsys_reason]) > NET_DM_MAX_REASON_LEN) {
> - list = rcu_dereference(drop_reasons_by_subsys[SKB_DROP_REASON_SUBSYS_CORE]);
> - subsys_reason = SKB_DROP_REASON_NOT_SPECIFIED;
> - }
Oops, I lost this translation of erroneous ones to the core
SKB_DROP_REASON_NOT_SPECIFIED.
Maybe we should just not have the attribute in that case? But that could
be a different change too.
> - if (nla_put_string(msg, NET_DM_ATTR_REASON,
> - list->reasons[subsys_reason])) {
> + reason_str = drop_reason_lookup(cb->reason);
> + if (nla_put_string(msg, NET_DM_ATTR_REASON, reason_str)) {
> rcu_read_unlock();
johannes
Powered by blists - more mailing lists