netdev - Re: [PATCH net-next 6/8] inet: implement lockless getsockopt(IP_UNICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04589a05-441a-1a55-b6e4-c266ca87eff2@kernel.org>
Date: Thu, 21 Sep 2023 13:19:26 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 6/8] inet: implement lockless
 getsockopt(IP_UNICAST_IF)

On 9/21/23 7:30 AM, Eric Dumazet wrote:
> Add missing READ_ONCE() annotations when reading inet->uc_index
> 
> Implementing getsockopt(IP_UNICAST_IF) locklessly seems possible,
> the setsockopt() part might not be possible at the moment.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/datagram.c    |  2 +-
>  net/ipv4/ip_sockglue.c | 10 +++++-----
>  net/ipv4/ping.c        |  2 +-
>  net/ipv4/raw.c         | 13 +++++++------
>  net/ipv4/udp.c         | 12 +++++++-----
>  5 files changed, 21 insertions(+), 18 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>