netdev - Re: [PATCH net-next 7/8] inet: lockless IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f53ebec-d3c8-8db2-7597-4d5a444a1786@kernel.org>
Date: Thu, 21 Sep 2023 13:23:20 -0600
From: David Ahern <dsahern@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 7/8] inet: lockless IP_PKTOPTIONS implementation

On 9/21/23 7:30 AM, Eric Dumazet wrote:
> Current implementation is already lockless, because the socket
> lock is released before reading socket fields.
> 
> Add missing READ_ONCE() annotations.
> 
> Note that corresponding WRITE_ONCE() are needed, the order
> of the patches do not really matter.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---
>  net/ipv4/ip_sockglue.c | 76 ++++++++++++++++++++----------------------
>  1 file changed, 37 insertions(+), 39 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>