netdev - Re: [PATCH net-next v2 0/3] Wangxun ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccf1a90b-4f5a-bcee-83fc-1bb85cb80d8b@intel.com>
Date: Thu, 21 Sep 2023 13:33:36 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <andrew@...n.ch>
CC: <mengyuanlou@...-swift.com>
Subject: Re: [PATCH net-next v2 0/3] Wangxun ethtool stats



On 9/20/2023 8:30 PM, Jiawen Wu wrote:
> Support to show ethtool stats for txgbe/ngbe.
> 
> v1 -> v2:
> - change struct wx_stats member types
> - use ethtool_sprintf()
> 
> Jiawen Wu (3):
>   net: libwx: support hardware statistics
>   net: txgbe: add ethtool stats support
>   net: ngbe: add ethtool stats support
> 

I probably wouldn't have done this as 3 separate patches, but the code
looks good to me.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  .../net/ethernet/wangxun/libwx/wx_ethtool.c   | 191 ++++++++++++++++++
>  .../net/ethernet/wangxun/libwx/wx_ethtool.h   |   4 +
>  drivers/net/ethernet/wangxun/libwx/wx_hw.c    | 116 +++++++++++
>  drivers/net/ethernet/wangxun/libwx/wx_hw.h    |   2 +
>  drivers/net/ethernet/wangxun/libwx/wx_lib.c   |  11 +-
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  80 ++++++++
>  .../net/ethernet/wangxun/ngbe/ngbe_ethtool.c  |   3 +
>  drivers/net/ethernet/wangxun/ngbe/ngbe_hw.c   |   2 +
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |   2 +
>  .../ethernet/wangxun/txgbe/txgbe_ethtool.c    |   3 +
>  drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c |   2 +
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   |   2 +
>  12 files changed, 416 insertions(+), 2 deletions(-)
>