netdev - Re: [PATCH v2 net-next 0/5] net_sched: sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMm87U7sGESCtcekr-Avsx4+WMnOS7HuNztJdE=G8VFs+g@mail.gmail.com>
Date: Wed, 20 Sep 2023 19:22:07 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Willem de Bruijn <willemb@...gle.com>, 
	Soheil Hassas Yeganeh <soheil@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, 
	Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements

On Wed, Sep 20, 2023 at 4:17 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> For FQ tenth anniversary, it was time for making it faster.
>
> The FQ part (as in Fair Queue) is rather expensive, because
> we have to classify packets and store them in a per-flow structure,
> and add this per-flow structure in a hash table. Then the RR lists
> also add cache line misses.
>
> Most fq qdisc are almost idle. Trying to share NIC bandwidth has
> no benefits, thus the qdisc could behave like a FIFO.
>
> This series brings a 5 % throughput increase in intensive
> tcp_rr workload, and 13 % increase for (unpaced) UDP packets.
>
> v2: removed an extra label (build bot).
>     Fix an accidental increase of stat_internal_packets counter
>     in fast path.
>     Added "constify qdisc_priv()" patch to allow fq_fastpath_check()
>     first parameter to be const.
>     typo on 'eligible' (Willem)

For the patchset:
Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal
> Eric Dumazet (5):
>   net_sched: constify qdisc_priv()
>   net_sched: sch_fq: struct sched_data reorg
>   net_sched: sch_fq: change how @inactive is tracked
>   net_sched: sch_fq: add fast path for mostly idle qdisc
>   net_sched: sch_fq: always garbage collect
>
>  include/net/pkt_sched.h        |   8 +-
>  include/uapi/linux/pkt_sched.h |   1 +
>  net/sched/sch_fq.c             | 148 +++++++++++++++++++++++----------
>  3 files changed, 110 insertions(+), 47 deletions(-)
>
> --
> 2.42.0.459.ge4e396fd5e-goog
>