netdev - Re: [PATCH ipsec-next 0/2] xfrm: policy: replace session decode with flow dissector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230921122208.GL224399@kernel.org>
Date: Thu, 21 Sep 2023 13:22:08 +0100
From: Simon Horman <horms@...nel.org>
To: Florian Westphal <fw@...len.de>
Cc: netdev@...r.kernel.org, nharold@...gle.com, lorenzo@...gle.com,
	benedictwong@...gle.com, steffen.klassert@...unet.com,
	herbert@...dor.apana.org.au
Subject: Re: [PATCH ipsec-next 0/2] xfrm: policy: replace session decode with
 flow dissector

On Mon, Sep 18, 2023 at 02:59:07PM +0200, Florian Westphal wrote:
> Remove the ipv4+ipv6 session decode functions and use generic flow
> dissector to populate the flowi for the policy lookup.
> 
> Changes since RFC:
> 
>  - Drop mobility header support.  I don't think that anyone uses
>    this.  MOBIKE doesn't appear to need this either.
>  - Drop fl6->flowlabel assignment, original code leaves it as 0.
> 
> There is no reason for this change other than to remove code.
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
> Florian Westphal (2):
>   xfrm: move mark and oif flowi decode into common code
>   xfrm: policy: replace session decode with flow dissector
> 
>  net/xfrm/xfrm_policy.c | 277 ++++++++++++++++-------------------------
>  1 file changed, 107 insertions(+), 170 deletions(-)

For series,

Reviewed-by: Simon Horman <horms@...nel.org>