netdev - Re: [PATCHv3 net 1/2] fib: convert fib_nh_is_v6 and nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21c58c78-1b76-745a-0a12-7532a569374b@kernel.org>
Date: Thu, 21 Sep 2023 07:03:20 -0600
From: David Ahern <dsahern@...nel.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ido Schimmel <idosch@...dia.com>, Benjamin Poirier <bpoirier@...dia.com>,
 Thomas Haller <thaller@...hat.com>,
 Stephen Hemminger <stephen@...workplumber.org>,
 Eric Dumazet <edumazet@...gle.com>,
 Nicolas Dichtel <nicolas.dichtel@...nd.com>, Ido Schimmel <idosch@...sch.org>
Subject: Re: [PATCHv3 net 1/2] fib: convert fib_nh_is_v6 and nh_updated to use
 a single bit

On 9/20/23 9:14 PM, Hangbin Liu wrote:
> The FIB info structure currently looks like this:
> struct fib_info {
>         struct hlist_node          fib_hash;             /*     0    16 */
>         [...]
>         u32                        fib_priority;         /*    80     4 */
> 
>         /* XXX 4 bytes hole, try to pack */
> 
>         struct dst_metrics *       fib_metrics;          /*    88     8 */
>         int                        fib_nhs;              /*    96     4 */
>         bool                       fib_nh_is_v6;         /*   100     1 */
>         bool                       nh_updated;           /*   101     1 */
> 
>         /* XXX 2 bytes hole, try to pack */

2B hole here and you want to add a single flag so another bool. I would
prefer the delay to a bitfield until all holes are consumed.