lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87pm2blvk3.fsf@toke.dk> Date: Thu, 21 Sep 2023 11:33:48 +0200 From: Toke Høiland-Jørgensen <toke@...hat.com> To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jamal Hadi Salim <jhs@...atatu.com> Cc: Eric Dumazet <edumazet@...gle.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Willem de Bruijn <willemb@...gle.com>, Soheil Hassas Yeganeh <soheil@...gle.com>, Neal Cardwell <ncardwell@...gle.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org, eric.dumazet@...il.com Subject: Re: [PATCH v2 net-next 0/5] net_sched: sch_fq: round of improvements Willem de Bruijn <willemdebruijn.kernel@...il.com> writes: > On Wed, Sep 20, 2023 at 7:22 PM Jamal Hadi Salim <jhs@...atatu.com> wrote: >> >> On Wed, Sep 20, 2023 at 4:17 PM Eric Dumazet <edumazet@...gle.com> wrote: >> > >> > For FQ tenth anniversary, it was time for making it faster. >> > >> > The FQ part (as in Fair Queue) is rather expensive, because >> > we have to classify packets and store them in a per-flow structure, >> > and add this per-flow structure in a hash table. Then the RR lists >> > also add cache line misses. >> > >> > Most fq qdisc are almost idle. Trying to share NIC bandwidth has >> > no benefits, thus the qdisc could behave like a FIFO. >> > >> > This series brings a 5 % throughput increase in intensive >> > tcp_rr workload, and 13 % increase for (unpaced) UDP packets. >> > >> > v2: removed an extra label (build bot). >> > Fix an accidental increase of stat_internal_packets counter >> > in fast path. >> > Added "constify qdisc_priv()" patch to allow fq_fastpath_check() >> > first parameter to be const. >> > typo on 'eligible' (Willem) >> >> For the patchset: >> Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com> > > Reviewed-by: Willem de Bruijn <willemb@...gle.com> Might as well join the party - nice set of improvements! :) Reviewed-by: Toke Høiland-Jørgensen <toke@...hat.com>
Powered by blists - more mailing lists