netdev - Re: [Intel-wired-lan] [PATCH iwl-next 0/2] ethtool: Add link mode maps for forced speeds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 22 Sep 2023 13:05:42 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Pawel Chmielewski <pawel.chmielewski@...el.com>, <netdev@...r.kernel.org>
CC: <andrew@...n.ch>, <aelior@...vell.com>, <manishc@...vell.com>,
	<intel-wired-lan@...ts.osuosl.org>, <horms@...nel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next 0/2] ethtool: Add link mode
 maps for forced speeds

On 9/21/23 15:51, Pawel Chmielewski wrote:
> The following patch set was initially a part of [1]. As the purpose of
> the original series was to add the support of the new hardware to the
> intel ice driver, the refactoring of advertised link modes mapping was
> extracted to a new set.
> The patch set adds a common mechanism for mapping Ethtool forced speeds
> with Ethtool supported link modes, which can be used in drivers code.
> 
> [1] https://lore.kernel.org/netdev/20230823180633.2450617-1-pawel.chmielewski@intel.com
> 
> Changelog:
> v1->v2:
> Fixed formatting, typo, moved declaration of iterator to loop line.
> 
> Paul Greenwalt (1):
>    ethtool: Add forced speed to supported link modes maps
> 
> Pawel Chmielewski (1):
>    ice: Refactor finding advertised link speed
> 
>   drivers/net/ethernet/intel/ice/ice.h          |   1 +
>   drivers/net/ethernet/intel/ice/ice_ethtool.c  | 201 ++++++++++++------
>   drivers/net/ethernet/intel/ice/ice_main.c     |   2 +
>   .../net/ethernet/qlogic/qede/qede_ethtool.c   |  24 +--
>   include/linux/ethtool.h                       |  20 ++
>   net/ethtool/ioctl.c                           |  15 ++
>   6 files changed, 178 insertions(+), 85 deletions(-)
> 

Thanks,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

(one minor whitespace error found,
for me personally we could go with it)