netdev - Re: [PATCH] ptp: ocp: Fix error handling in ptp_ocp_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b5704d6-3eca-70a8-4dc4-3a37653e3956@linux.dev>
Date: Fri, 22 Sep 2023 12:28:47 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Dinghao Liu <dinghao.liu@....edu.cn>
Cc: Richard Cochran <richardcochran@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, Vadim Fedorenko <vadfed@...com>,
 "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ptp: ocp: Fix error handling in ptp_ocp_device_init

On 22/09/2023 10:40, Dinghao Liu wrote:
> When device_add() fails, ptp_ocp_dev_release() will be called
> after put_device(). Therefore, it seems that the
> ptp_ocp_dev_release() before put_device() is redundant.
> 
> Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the timecard.")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>

Thanks!

Reviewed-by: Vadim Feodrenko <vadim.fedorenko@...ux.dev>