netdev - Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230922154546.4ca18b6f@bootlin.com>
Date: Fri, 22 Sep 2023 15:45:46 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Rob Herring <robh@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, Randy Dunlap
 <rdunlap@...radead.org>, Takashi Iwai <tiwai@...e.com>, Simon Horman
 <horms@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Liam Girdwood
 <lgirdwood@...il.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-gpio@...r.kernel.org, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@...aro.org>, netdev@...r.kernel.org, Fabio Estevam
 <festevam@...il.com>, Eric Dumazet <edumazet@...gle.com>, Andrew Lunn
 <andrew@...n.ch>, Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Christophe Leroy <christophe.leroy@...roup.eu>, Nicolin Chen
 <nicoleotsuka@...il.com>, Conor Dooley <conor+dt@...nel.org>, Mark Brown
 <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
 alsa-devel@...a-project.org, Paolo Abeni <pabeni@...hat.com>, Lee Jones
 <lee@...nel.org>, linux-kernel@...r.kernel.org, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Xiubo Li
 <Xiubo.Lee@...il.com>, Rob Herring <robh+dt@...nel.org>, Shengjiu Wan g
 <shengjiu.wang@...il.com>, linuxppc-dev@...ts.ozlabs.org,
 devicetree@...r.kernel.org, Li Yang <leoyang.li@....com>, Qiang Zhao
 <qiang.zhao@....com>
Subject: Re: [PATCH v6 25/30] dt-bindings: net: Add the Lantiq PEF2256
 E1/T1/J1 framer

Hi Rob,

On Fri, 22 Sep 2023 07:33:32 -0500
Rob Herring <robh@...nel.org> wrote:

> On Fri, 22 Sep 2023 09:59:00 +0200, Herve Codina wrote:
> > The Lantiq PEF2256 is a framer and line interface component designed to
> > fulfill all required interfacing between an analog E1/T1/J1 line and the
> > digital PCM system highway/H.100 bus.
> > 
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> > Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> > ---
> >  .../bindings/net/lantiq,pef2256.yaml          | 214 ++++++++++++++++++
> >  1 file changed, 214 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
> >   
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/lantiq,pef2256.yaml: properties:lantiq,data-rate-bps: '$ref' should not be valid under {'const': '$ref'}
> 	hint: Standard unit suffix properties don't need a type $ref
> 	from schema $id: http://devicetree.org/meta-schemas/core.yaml#
> 

The '-bps' suffix was added recently in
https://github.com/devicetree-org/dt-schema/
commit 033d0b1 ("Add '-bps' as a standard unit suffix for bits per second")

This commit is not yet present in any dt-schema release.

Should I update my patch (ie. removing $ref) right now even if this update will
make the last dt-schema release not happy ?

Regards,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com