netdev - Re: [PATCH net-next v3 09/18] net/smc: introduce SMC-D loopback device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39f264e0-bcc4-97f8-57ca-8a8bee28c27b@linux.alibaba.com>
Date: Fri, 22 Sep 2023 15:55:14 +0800
From: Wen Gu <guwen@...ux.alibaba.com>
To: Wenjia Zhang <wenjia@...ux.ibm.com>, kgraul@...ux.ibm.com,
 jaka@...ux.ibm.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com
Cc: alibuda@...ux.alibaba.com, tonylu@...ux.alibaba.com,
 linux-s390@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 09/18] net/smc: introduce SMC-D loopback
 device



On 2023/9/22 07:32, Wenjia Zhang wrote:
> 
> 

<..>

>> +
>> +#ifndef _SMC_LOOPBACK_H
>> +#define _SMC_LOOPBACK_H
>> +
>> +#include <linux/device.h>
>> +#include <linux/err.h>
>> +#include <net/smc.h>
>> +
>> +#define SMC_LODEV_MAX_DMBS 5000
>> +
>> +struct smc_lo_dev {
>> +    struct smcd_dev *smcd;
>> +    struct device dev;
>> +};
>> +
> I'm just wondering why don't use pointer for dev?
> 

The 'struct device' is a generic structure embeded, used to associate a Linux device
with a specific device. So I think variable for dev here is OK. See also struct ism_dev.

Thanks.

>> +int smc_loopback_init(void);
>> +void smc_loopback_exit(void);
>> +
>> +#endif /* _SMC_LOOPBACK_H */