netdev - Re: [PATCH net-next 4/4] tcp_metrics: optimize tcp_metrics_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADVnQymE1cjkisOpT0235RbhxeH0PBD-Qu_5+BSLQQOHABx3jw@mail.gmail.com>
Date: Sun, 24 Sep 2023 12:08:48 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Yuchung Cheng <ycheng@...gle.com>, netdev@...r.kernel.org, 
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 4/4] tcp_metrics: optimize tcp_metrics_flush_all()

On Fri, Sep 22, 2023 at 6:04 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> This is inspired by several syzbot reports where
> tcp_metrics_flush_all() was seen in the traces.
>
> We can avoid acquiring tcp_metrics_lock for empty buckets,
> and we should add one cond_resched() to break potential long loops.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal