netdev - Re: [PATCH iwl-next] idpf: set scheduling mode for completion queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82dacc0d-efa1-35d2-b912-ac1622a57d84@intel.com>
Date: Mon, 25 Sep 2023 10:40:44 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Michal Kubiak <michal.kubiak@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <aleksander.lobakin@...el.com>, <larysa.zaremba@...el.com>,
	<alan.brady@...el.com>, <joshua.a.hay@...el.com>,
	<emil.s.tantilov@...el.com>, <netdev@...r.kernel.org>
Subject: Re: [PATCH iwl-next] idpf: set scheduling mode for completion queue

On 9/22/23 18:16, Michal Kubiak wrote:
> The HW must be programmed differently for queue-based scheduling mode.
> To program the completion queue context correctly, the control plane
> must know the scheduling mode not only for the Tx queue, but also for
> the completion queue.
> Unfortunately, currently the driver sets the scheduling mode only for
> the Tx queues.
> 
> Propagate the scheduling mode data for the completion queue as
> well when sending the queue configuration messages.
> 
> Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues")
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Michal Kubiak <michal.kubiak@...el.com>
> ---
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c     | 10 ++++++++--
>   drivers/net/ethernet/intel/idpf/idpf_virtchnl.c |  8 +++++++-
>   2 files changed, 15 insertions(+), 3 deletions(-)
> 

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>