| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <xwcwjtyy5yx6pruoa3vmssnjzkbeahmfyym4e5lrq2efcwwiym@2upf4ko4mah5>
Date: Tue, 26 Sep 2023 14:25:56 +0300
From: Serge Semin <fancer.lancer@...il.com>
To: Rohan G Thomas <rohan.g.thomas@...el.com>
Cc: "David S . Miller" <davem@...emloft.net>,
Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH net-next 1/1] net: stmmac: xgmac: EST interrupts handling
Hi Rohan
On Sat, Sep 23, 2023 at 11:10:31AM +0800, Rohan G Thomas wrote:
> Enabled the following EST related interrupts:
> 1) Constant Gate Control Error (CGCE)
> 2) Head-of-Line Blocking due to Scheduling (HLBS)
> 3) Head-of-Line Blocking due to Frame Size (HLBF)
> 4) Base Time Register error (BTRE)
> 5) Switch to S/W owned list Complete (SWLC)
> Also, add EST errors into the ethtool statistic.
>
> The commit e49aa315cb01 ("net: stmmac: EST interrupts handling and
> error reporting") and commit 9f298959191b ("net: stmmac: Add EST
> errors into ethtool statistic") add EST interrupts handling and error
> reporting support to DWMAC4 core. This patch enables the same support
> for XGMAC.
So, this is basically a copy of what was done for the DW QoS Eth
IP-core (DW GMAC v4.x/v5.x). IMO it would be better to factor it out
into a separate module together with the rest of the setup methods
like it's done for TC or PTP. But since it implies some much more work
I guess we can leave it as is for now...
Reviewed-by: Serge Semin <fancer.lancer@...il.com>
-Serge(y)
>
> Signed-off-by: Rohan G Thomas <rohan.g.thomas@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> .../net/ethernet/stmicro/stmmac/dwxgmac2.h | 27 ++++++
> .../ethernet/stmicro/stmmac/dwxgmac2_core.c | 89 +++++++++++++++++++
> 2 files changed, 116 insertions(+)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> index 7a8f47e7b728..75782b8cdfe9 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h
> @@ -289,6 +289,33 @@
> #define XGMAC_PTOV_SHIFT 23
> #define XGMAC_SSWL BIT(1)
> #define XGMAC_EEST BIT(0)
> +#define XGMAC_MTL_EST_STATUS 0x00001058
> +#define XGMAC_BTRL GENMASK(15, 8)
> +#define XGMAC_BTRL_SHIFT 8
> +#define XGMAC_BTRL_MAX GENMASK(15, 8)
> +#define XGMAC_CGCE BIT(4)
> +#define XGMAC_HLBS BIT(3)
> +#define XGMAC_HLBF BIT(2)
> +#define XGMAC_BTRE BIT(1)
> +#define XGMAC_SWLC BIT(0)
> +#define XGMAC_MTL_EST_SCH_ERR 0x00001060
> +#define XGMAC_MTL_EST_FRM_SZ_ERR 0x00001064
> +#define XGMAC_MTL_EST_FRM_SZ_CAP 0x00001068
> +#define XGMAC_SZ_CAP_HBFS_MASK GENMASK(14, 0)
> +#define XGMAC_SZ_CAP_HBFQ_SHIFT 16
> +#define XGMAC_SZ_CAP_HBFQ_MASK(val) \
> + ({ \
> + typeof(val) _val = (val); \
> + (_val > 4 ? GENMASK(18, 16) : \
> + _val > 2 ? GENMASK(17, 16) : \
> + BIT(16)); \
> + })
> +#define XGMAC_MTL_EST_INT_EN 0x00001070
> +#define XGMAC_IECGCE BIT(4)
> +#define XGMAC_IEHS BIT(3)
> +#define XGMAC_IEHF BIT(2)
> +#define XGMAC_IEBE BIT(1)
> +#define XGMAC_IECC BIT(0)
> #define XGMAC_MTL_EST_GCL_CONTROL 0x00001080
> #define XGMAC_BTR_LOW 0x0
> #define XGMAC_BTR_HIGH 0x1
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> index f352be269deb..0af0aefa6656 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c
> @@ -1469,9 +1469,97 @@ static int dwxgmac3_est_configure(void __iomem *ioaddr, struct stmmac_est *cfg,
> ctrl &= ~XGMAC_EEST;
>
> writel(ctrl, ioaddr + XGMAC_MTL_EST_CONTROL);
> +
> + /* Configure EST interrupt */
> + if (cfg->enable)
> + ctrl = XGMAC_IECGCE | XGMAC_IEHS | XGMAC_IEHF | XGMAC_IEBE |
> + XGMAC_IECC;
> + else
> + ctrl = 0;
> +
> + writel(ctrl, ioaddr + XGMAC_MTL_EST_INT_EN);
> return 0;
> }
>
> +static void dwxgmac3_est_irq_status(void __iomem *ioaddr,
> + struct net_device *dev,
> + struct stmmac_extra_stats *x, u32 txqcnt)
> +{
> + u32 status, value, feqn, hbfq, hbfs, btrl;
> + u32 txqcnt_mask = BIT(txqcnt) - 1;
> +
> + status = readl(ioaddr + XGMAC_MTL_EST_STATUS);
> +
> + value = XGMAC_CGCE | XGMAC_HLBS | XGMAC_HLBF | XGMAC_BTRE | XGMAC_SWLC;
> +
> + /* Return if there is no error */
> + if (!(status & value))
> + return;
> +
> + if (status & XGMAC_CGCE) {
> + /* Clear Interrupt */
> + writel(XGMAC_CGCE, ioaddr + XGMAC_MTL_EST_STATUS);
> +
> + x->mtl_est_cgce++;
> + }
> +
> + if (status & XGMAC_HLBS) {
> + value = readl(ioaddr + XGMAC_MTL_EST_SCH_ERR);
> + value &= txqcnt_mask;
> +
> + x->mtl_est_hlbs++;
> +
> + /* Clear Interrupt */
> + writel(value, ioaddr + XGMAC_MTL_EST_SCH_ERR);
> +
> + /* Collecting info to shows all the queues that has HLBS
> + * issue. The only way to clear this is to clear the
> + * statistic.
> + */
> + if (net_ratelimit())
> + netdev_err(dev, "EST: HLB(sched) Queue 0x%x\n", value);
> + }
> +
> + if (status & XGMAC_HLBF) {
> + value = readl(ioaddr + XGMAC_MTL_EST_FRM_SZ_ERR);
> + feqn = value & txqcnt_mask;
> +
> + value = readl(ioaddr + XGMAC_MTL_EST_FRM_SZ_CAP);
> + hbfq = (value & XGMAC_SZ_CAP_HBFQ_MASK(txqcnt)) >>
> + XGMAC_SZ_CAP_HBFQ_SHIFT;
> + hbfs = value & XGMAC_SZ_CAP_HBFS_MASK;
> +
> + x->mtl_est_hlbf++;
> +
> + /* Clear Interrupt */
> + writel(feqn, ioaddr + XGMAC_MTL_EST_FRM_SZ_ERR);
> +
> + if (net_ratelimit())
> + netdev_err(dev, "EST: HLB(size) Queue %u Size %u\n",
> + hbfq, hbfs);
> + }
> +
> + if (status & XGMAC_BTRE) {
> + if ((status & XGMAC_BTRL) == XGMAC_BTRL_MAX)
> + x->mtl_est_btrlm++;
> + else
> + x->mtl_est_btre++;
> +
> + btrl = (status & XGMAC_BTRL) >> XGMAC_BTRL_SHIFT;
> +
> + if (net_ratelimit())
> + netdev_info(dev, "EST: BTR Error Loop Count %u\n",
> + btrl);
> +
> + writel(XGMAC_BTRE, ioaddr + XGMAC_MTL_EST_STATUS);
> + }
> +
> + if (status & XGMAC_SWLC) {
> + writel(XGMAC_SWLC, ioaddr + XGMAC_MTL_EST_STATUS);
> + netdev_info(dev, "EST: SWOL has been switched\n");
> + }
> +}
> +
> static void dwxgmac3_fpe_configure(void __iomem *ioaddr, u32 num_txq,
> u32 num_rxq, bool enable)
> {
> @@ -1541,6 +1629,7 @@ const struct stmmac_ops dwxgmac210_ops = {
> .config_l4_filter = dwxgmac2_config_l4_filter,
> .set_arp_offload = dwxgmac2_set_arp_offload,
> .est_configure = dwxgmac3_est_configure,
> + .est_irq_status = dwxgmac3_est_irq_status,
> .fpe_configure = dwxgmac3_fpe_configure,
> };
>
> --
> 2.26.2
>
>
Powered by blists - more mailing lists