netdev - Re: [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in prueth_init_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 27 Sep 2023 14:29:12 +0300
From: Roger Quadros <rogerq@...com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni
	<pabeni@...hat.com>, MD Danish Anwar <danishanwar@...com>,
        Andrew Lunn
	<andrew@...n.ch>,
        Grygorii Strashko <grygorii.strashko@...com>,
        "Vignesh
 Raghavendra" <vigneshr@...com>, <netdev@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/3 net] net: ti: icssg-prueth: Fix signedness bug in
 prueth_init_tx_chns()



On 26.9.2023 17.05, Dan Carpenter wrote:
> The "tx_chn->irq" variable is unsigned so the error checking does not
> work correctly.
> 
> Fixes: 128d5874c082 ("net: ti: icssg-prueth: Add ICSSG ethernet driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Roger Quadros <rogerq@...nel.org>