netdev - Re: [PATCH net-next v2 1/9] bnxt_en: Update firmware interface to 1.10.2.171

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLikQ=q2TfEYrJhEemDqmK5HBFJxTJORrKTriL2SMCgLYxA@mail.gmail.com>
Date: Wed, 27 Sep 2023 10:20:53 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com
Subject: Re: [PATCH net-next v2 1/9] bnxt_en: Update firmware interface to 1.10.2.171

On Wed, Sep 27, 2023 at 5:34 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Tue, Sep 26, 2023 at 08:57:26PM -0700, Michael Chan wrote:
> > The main changes are the additional thermal thresholds in
> > hwrm_temp_monitor_query_output and the new async event to
> > report thermal errors.
>
> A quick question. Is this backwards compatible with older firmware?

Yes, a newer interface is always compatible with older firmware using
older interfaces except very old pre-production interface versions
below 1.0.0.

>
> > -#define HWRM_VERSION_RSVD 118
> > -#define HWRM_VERSION_STR "1.10.2.118"
> > +#define HWRM_VERSION_RSVD 171
> > +#define HWRM_VERSION_STR "1.10.2.171"
>
> These don't appear to be used anywhere?
>

In bnxt_hwrm_ver_get(), we exchange the major, minor, and update
interface versions (1.10.2 in this case) with the firmware (but not
the reserved version).  All changes are compatible but a major or
minor version update may introduce bigger changes.