netdev - Re: [PATCH ipsec-next 2/2] xfrm: policy: replace session decode with flow dissector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230927180129.GD17767@breakpoint.cc>
Date: Wed, 27 Sep 2023 20:01:29 +0200
From: Florian Westphal <fw@...len.de>
To: kernel test robot <oliver.sang@...el.com>
Cc: Florian Westphal <fw@...len.de>, oe-lkp@...ts.linux.dev, lkp@...el.com,
	netdev@...r.kernel.org, nharold@...gle.com, lorenzo@...gle.com,
	benedictwong@...gle.com, steffen.klassert@...unet.com,
	herbert@...dor.apana.org.au
Subject: Re: [PATCH ipsec-next 2/2] xfrm: policy: replace session decode with
 flow dissector

kernel test robot <oliver.sang@...el.com> wrote:
> (please refer to attached dmesg/kmsg for entire log/backtrace)
> 
> 
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <oliver.sang@...el.com>
> | Closes: https://lore.kernel.org/oe-lkp/202309271628.27fd2187-oliver.sang@intel.com
> 
> 
> kern  :warn  : [  173.147140] ------------[ cut here ]------------
> kern :warn : [  173.147759] WARNING: CPU: 12 PID: 2260 at net/core/flow_dissector.c:1096 __skb_flow_dissect (net/core/flow_dissector.c:1096 (discriminator 1)) 

Two options, more 'guess the right netns' in flow dissector:
derive netns from skb->dst->dev.

Or, pass struct net down to xfrm session decode functions.

I'll have a go at option 2 to see how much noise its going to be.