netdev - Re: [PATCH net-next] can: sja1000: Fix comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Sep 2023 14:35:56 +0200
From: Simon Horman <horms@...nel.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Wolfgang Grandegger <wg@...ndegger.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
	linux-can@...r.kernel.org,
	Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	sylvain.girard@...com, pascal.eberhard@...com
Subject: Re: [PATCH net-next] can: sja1000: Fix comment

On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote:
> There is likely a copy-paste error here, as the exact same comment
> appears below in this function, one time calling set_reset_mode(), the
> other set_normal_mode().
> 
> Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")

I'm not sure this warrants a fixes tag, which implies backporting,
but in any case the tag is correct.

> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>

The above comment notwithstanding, this seems correct to me.

Reviewed-by: Simon Horman <horms@...nel.org>