netdev - Re: [PATCH 13/15] raid: Remove now superfluous sentinel element from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date: Thu, 28 Sep 2023 08:20:34 -0700
From: Song Liu <song@...nel.org>
To: j.granados@...sung.com
Cc: Luis Chamberlain <mcgrof@...nel.org>, willy@...radead.org, josh@...htriplett.org, 
	Kees Cook <keescook@...omium.org>, Phillip Potter <phil@...lpotter.co.uk>, 
	Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Juergen Gross <jgross@...e.com>, 
	Stefano Stabellini <sstabellini@...nel.org>, 
	Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>, Jiri Slaby <jirislaby@...nel.org>, 
	"James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, 
	Doug Gilbert <dgilbert@...erlog.com>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, 
	Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Corey Minyard <minyard@....org>, 
	"Theodore Ts'o" <tytso@....edu>, "Jason A. Donenfeld" <Jason@...c4.com>, David Ahern <dsahern@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Robin Holt <robinmholt@...il.com>, 
	Steve Wahl <steve.wahl@....com>, Russ Weight <russell.h.weight@...el.com>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, 
	Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, 
	Dexuan Cui <decui@...rosoft.com>, Jani Nikula <jani.nikula@...ux.intel.com>, 
	Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, 
	Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, David Airlie <airlied@...il.com>, 
	Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org, 
	xen-devel@...ts.xenproject.org, linux-serial@...r.kernel.org, 
	linux-scsi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-rdma@...r.kernel.org, openipmi-developer@...ts.sourceforge.net, 
	netdev@...r.kernel.org, linux-raid@...r.kernel.org, 
	linux-hyperv@...r.kernel.org, intel-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 13/15] raid: Remove now superfluous sentinel element from
 ctl_table array

On Thu, Sep 28, 2023 at 6:20 AM Joel Granados via B4 Relay
<devnull+j.granados.samsung.com@...nel.org> wrote:
>
> From: Joel Granados <j.granados@...sung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel from raid_table
>
> Signed-off-by: Joel Granados <j.granados@...sung.com>
> ---
>  drivers/md/md.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index a104a025084d..3866d8f754a0 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -304,8 +304,7 @@ static struct ctl_table raid_table[] = {
>                 .maxlen         = sizeof(int),
>                 .mode           = S_IRUGO|S_IWUSR,
>                 .proc_handler   = proc_dointvec,
> -       },
> -       { }
> +       }
>  };

Please keep "}," as Greg suggested. Otherwise,

Acked-by: Song Liu <song@...nel.org>

Thanks,
Song