netdev - RE: [EXT] Re: [PATCH net] octeontx2-pf: Fix page pool frag allocation failure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <MWHPR1801MB1918CD574039BCBBF9787674D3C0A@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date: Fri, 29 Sep 2023 03:15:27 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Yunsheng Lin <linyunsheng@...wei.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "alexander.duyck@...il.com"
	<alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org"
	<ilias.apalodimas@...aro.org>,
        "bigeasy@...utronix.de"
	<bigeasy@...utronix.de>
Subject: RE: [EXT] Re: [PATCH net] octeontx2-pf: Fix page pool frag allocation
 failure.

> From: Yunsheng Lin <linyunsheng@...wei.com>
> Subject: [EXT] Re: [PATCH net] octeontx2-pf: Fix page pool frag allocation
> failure.
> 


> If I understand it correctly, it is not a crash, but a warning as the requsted size
> is bigger than PAGE_SIZE for order 0, so the below checking triggered the
> warning, right?
Yes.  Will change commit message ( s/crash/warn)


> > +	sz = ALIGN(ALIGN(SKB_DATA_ALIGN(buf_size), OTX2_ALIGN),
> PAGE_SIZE);
> > +	pp_params.order = (sz / PAGE_SIZE) - 1;
> 
> Perhaps use PAGE_ALIGN() and get_order() for the above?
ACK

-Ratheesh