| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202309291312.vJyV8G9L-lkp@intel.com>
Date: Fri, 29 Sep 2023 13:57:07 +0800
From: kernel test robot <lkp@...el.com>
To: David Morley <morleyd.kernel@...il.com>,
David Miller <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
netdev@...r.kernel.org, David Morley <morleyd@...gle.com>,
Neal Cardwell <ncardwell@...gle.com>,
Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net-next 1/2] tcp: record last received ipv6 flowlabel
Hi David,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/David-Morley/tcp-change-data-receiver-flowlabel-after-one-dup/20230928-022955
base: net-next/main
patch link: https://lore.kernel.org/r/20230927182747.2005960-1-morleyd.kernel%40gmail.com
patch subject: [PATCH net-next 1/2] tcp: record last received ipv6 flowlabel
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230929/202309291312.vJyV8G9L-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230929/202309291312.vJyV8G9L-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309291312.vJyV8G9L-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/dccp/timer.c:199:25: warning: comparison of distinct pointer types ('typeof (icsk->icsk_ack.ato << 1) *' (aka 'int *') and 'typeof (icsk->icsk_rto) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]
icsk->icsk_ack.ato = min(icsk->icsk_ack.ato << 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:68:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:37:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:27:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:21:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
1 warning generated.
vim +199 net/dccp/timer.c
4ed800d02cfb63 Gerrit Renker 2006-11-13 168
4ed800d02cfb63 Gerrit Renker 2006-11-13 169 /* This is the same as tcp_delack_timer, sans prequeue & mem_reclaim stuff */
59f379f9046a9e Kees Cook 2017-10-16 170 static void dccp_delack_timer(struct timer_list *t)
4ed800d02cfb63 Gerrit Renker 2006-11-13 171 {
59f379f9046a9e Kees Cook 2017-10-16 172 struct inet_connection_sock *icsk =
59f379f9046a9e Kees Cook 2017-10-16 173 from_timer(icsk, t, icsk_delack_timer);
59f379f9046a9e Kees Cook 2017-10-16 174 struct sock *sk = &icsk->icsk_inet.sk;
4ed800d02cfb63 Gerrit Renker 2006-11-13 175
4ed800d02cfb63 Gerrit Renker 2006-11-13 176 bh_lock_sock(sk);
4ed800d02cfb63 Gerrit Renker 2006-11-13 177 if (sock_owned_by_user(sk)) {
4ed800d02cfb63 Gerrit Renker 2006-11-13 178 /* Try again later. */
02a1d6e7a6bb02 Eric Dumazet 2016-04-27 179 __NET_INC_STATS(sock_net(sk), LINUX_MIB_DELAYEDACKLOCKED);
4ed800d02cfb63 Gerrit Renker 2006-11-13 180 sk_reset_timer(sk, &icsk->icsk_delack_timer,
4ed800d02cfb63 Gerrit Renker 2006-11-13 181 jiffies + TCP_DELACK_MIN);
4ed800d02cfb63 Gerrit Renker 2006-11-13 182 goto out;
4ed800d02cfb63 Gerrit Renker 2006-11-13 183 }
4ed800d02cfb63 Gerrit Renker 2006-11-13 184
4ed800d02cfb63 Gerrit Renker 2006-11-13 185 if (sk->sk_state == DCCP_CLOSED ||
4ed800d02cfb63 Gerrit Renker 2006-11-13 186 !(icsk->icsk_ack.pending & ICSK_ACK_TIMER))
4ed800d02cfb63 Gerrit Renker 2006-11-13 187 goto out;
4ed800d02cfb63 Gerrit Renker 2006-11-13 188 if (time_after(icsk->icsk_ack.timeout, jiffies)) {
4ed800d02cfb63 Gerrit Renker 2006-11-13 189 sk_reset_timer(sk, &icsk->icsk_delack_timer,
4ed800d02cfb63 Gerrit Renker 2006-11-13 190 icsk->icsk_ack.timeout);
4ed800d02cfb63 Gerrit Renker 2006-11-13 191 goto out;
4ed800d02cfb63 Gerrit Renker 2006-11-13 192 }
4ed800d02cfb63 Gerrit Renker 2006-11-13 193
4ed800d02cfb63 Gerrit Renker 2006-11-13 194 icsk->icsk_ack.pending &= ~ICSK_ACK_TIMER;
4ed800d02cfb63 Gerrit Renker 2006-11-13 195
4ed800d02cfb63 Gerrit Renker 2006-11-13 196 if (inet_csk_ack_scheduled(sk)) {
31954cd8bb6670 Wei Wang 2019-01-25 197 if (!inet_csk_in_pingpong_mode(sk)) {
4ed800d02cfb63 Gerrit Renker 2006-11-13 198 /* Delayed ACK missed: inflate ATO. */
4ed800d02cfb63 Gerrit Renker 2006-11-13 @199 icsk->icsk_ack.ato = min(icsk->icsk_ack.ato << 1,
4ed800d02cfb63 Gerrit Renker 2006-11-13 200 icsk->icsk_rto);
4ed800d02cfb63 Gerrit Renker 2006-11-13 201 } else {
4ed800d02cfb63 Gerrit Renker 2006-11-13 202 /* Delayed ACK missed: leave pingpong mode and
4ed800d02cfb63 Gerrit Renker 2006-11-13 203 * deflate ATO.
4ed800d02cfb63 Gerrit Renker 2006-11-13 204 */
31954cd8bb6670 Wei Wang 2019-01-25 205 inet_csk_exit_pingpong_mode(sk);
4ed800d02cfb63 Gerrit Renker 2006-11-13 206 icsk->icsk_ack.ato = TCP_ATO_MIN;
4ed800d02cfb63 Gerrit Renker 2006-11-13 207 }
4ed800d02cfb63 Gerrit Renker 2006-11-13 208 dccp_send_ack(sk);
02a1d6e7a6bb02 Eric Dumazet 2016-04-27 209 __NET_INC_STATS(sock_net(sk), LINUX_MIB_DELAYEDACKS);
4ed800d02cfb63 Gerrit Renker 2006-11-13 210 }
4ed800d02cfb63 Gerrit Renker 2006-11-13 211 out:
4ed800d02cfb63 Gerrit Renker 2006-11-13 212 bh_unlock_sock(sk);
4ed800d02cfb63 Gerrit Renker 2006-11-13 213 sock_put(sk);
4ed800d02cfb63 Gerrit Renker 2006-11-13 214 }
4ed800d02cfb63 Gerrit Renker 2006-11-13 215
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists