lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87fs2xflrw.fsf@cloudflare.com> Date: Fri, 29 Sep 2023 10:02:55 +0200 From: Jakub Sitnicki <jakub@...udflare.com> To: John Fastabend <john.fastabend@...il.com> Cc: daniel@...earbox.net, ast@...nel.org, andrii@...nel.org, bpf@...r.kernel.org, netdev@...r.kernel.org, edumazet@...gle.com Subject: Re: [PATCH bpf v3 0/3] bpf, sockmap complete fixes for avail bytes On Mon, Sep 25, 2023 at 08:52 PM -07, John Fastabend wrote: > With e5c6de5fa0258 ("bpf, sockmap: Incorrectly handling copied_seq") we > started fixing the available bytes accounting by moving copied_seq to > where the user actually reads the bytes. > > However we missed handling MSG_PEEK correctly and we need to ensure > that we don't kfree_skb() a skb off the receive_queue when the > copied_seq number is not incremented by user reads for some time. > > v2: drop seq var in tcp_read_skb its no longer necessary per Jakub's > suggestion Credit goes to Simon Horman. > v3: drop tcp_sock as well its also not used anymore. sorry for the extra > noise there. > > John Fastabend (3): > bpf: tcp_read_skb needs to pop skb regardless of seq > bpf: sockmap, do not inc copied_seq when PEEK flag set > bpf: sockmap, add tests for MSG_F_PEEK > > net/ipv4/tcp.c | 10 +--- > net/ipv4/tcp_bpf.c | 4 +- > .../selftests/bpf/prog_tests/sockmap_basic.c | 52 +++++++++++++++++++ > 3 files changed, 57 insertions(+), 9 deletions(-) For the series: Reviewed-by: Jakub Sitnicki <jakub@...udflare.com>
Powered by blists - more mailing lists