netdev - Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel element from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230929121558.pvsbbnxlijawaioz@localhost>
Date: Fri, 29 Sep 2023 14:15:58 +0200
From: Joel Granados <j.granados@...sung.com>
To: Wei Liu <wei.liu@...nel.org>
CC: Luis Chamberlain <mcgrof@...nel.org>, <willy@...radead.org>,
	<josh@...htriplett.org>, Kees Cook <keescook@...omium.org>, Phillip Potter
	<phil@...lpotter.co.uk>, Clemens Ladisch <clemens@...isch.de>, Arnd Bergmann
	<arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Juergen
	Gross <jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>, Jiri Slaby
	<jirislaby@...nel.org>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin
 K. Petersen" <martin.petersen@...cle.com>, Doug Gilbert
	<dgilbert@...erlog.com>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Jason
	Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Corey Minyard
	<minyard@....org>, Theodore Ts'o <tytso@....edu>, "Jason A. Donenfeld"
	<Jason@...c4.com>, David Ahern <dsahern@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Robin Holt
	<robinmholt@...il.com>, Steve Wahl <steve.wahl@....com>, Russ Weight
	<russell.h.weight@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Song
	Liu <song@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang
	<haiyangz@...rosoft.com>, Dexuan Cui <decui@...rosoft.com>, Jani Nikula
	<jani.nikula@...ux.intel.com>, Joonas Lahtinen
	<joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>, David Airlie
	<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	<linux-serial@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-rdma@...r.kernel.org>,
	<openipmi-developer@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	<linux-raid@...r.kernel.org>, <linux-hyperv@...r.kernel.org>,
	<intel-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 14/15] hyper-v/azure: Remove now superfluous sentinel
 element from ctl_table array

On Thu, Sep 28, 2023 at 03:26:16PM +0000, Wei Liu wrote:
> Please change the prefix to "Drivers: hv:" in the subject line in the
> two patches.
> 
> On Thu, Sep 28, 2023 at 03:21:39PM +0200, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@...sung.com>
> > 
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > 
> > Remove sentinel from hv_ctl_table
> > 
> > Signed-off-by: Joel Granados <j.granados@...sung.com>
> > ---
> >  drivers/hv/hv_common.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> > index ccad7bca3fd3..bc7d678030aa 100644
> > --- a/drivers/hv/hv_common.c
> > +++ b/drivers/hv/hv_common.c
> > @@ -147,8 +147,7 @@ static struct ctl_table hv_ctl_table[] = {
> >  		.proc_handler	= proc_dointvec_minmax,
> >  		.extra1		= SYSCTL_ZERO,
> >  		.extra2		= SYSCTL_ONE
> > -	},
> > -	{}
> > +	}
> 
> Please keep the comma at the end.
My V2 will have this.

> 
> >  };
> >  
> >  static int hv_die_panic_notify_crash(struct notifier_block *self,
> > 
> > -- 
> > 2.30.2
> > 

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)