lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8577c007-556f-4fca-8b74-075399223f06@intel.com> Date: Sun, 1 Oct 2023 08:50:01 +0300 From: "Neftin, Sasha" <sasha.neftin@...el.com> To: Simon Horman <horms@...nel.org>, Prasad Koya <prasad@...sta.com>, "Andrew Lunn" <andrew@...n.ch> CC: <intel-wired-lan@...ts.osuosl.org>, <kuba@...nel.org>, <davem@...emloft.net>, <pabeni@...hat.com>, <dumazet@...gle.com>, <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>, <netdev@...r.kernel.org>, "Lifshits, Vitaly" <vitaly.lifshits@...el.com> Subject: Re: [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings" On 30/09/2023 19:17, Simon Horman wrote: > On Fri, Sep 22, 2023 at 09:38:04AM -0700, Prasad Koya wrote: >> This reverts commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2. >> >> After the command "ethtool -s enps0 speed 100 duplex full autoneg on", >> i.e., advertise only 100Mbps speed to the peer, "ethtool enps0" shows >> advertised speeds as 100Mbps and 2500Mbps. Same behavior is seen >> when changing the speed to 10Mbps or 1000Mbps. >> >> This applies to I225/226 parts, which only supports copper mode. >> Reverting to original till the ambiguity is resolved. >> >> Fixes: 9ac3fc2f42e5 ("igc: set TP bit in 'supported' and >> 'advertising' fields of ethtool_link_ksettings") > > nit: I don't think it is correct to linewrap Fixes tags. Simon, we decided not to recall this patch and will submit another one. (resolve 2500M and TP advertisement ambiguity). > >> Signed-off-by: Prasad Koya <prasad@...sta.com> > > ...
Powered by blists - more mailing lists