netdev - Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 2 Oct 2023 09:39:32 +0200
From: Joel Granados <j.granados@...sung.com>
To: Phillip Potter <phil@...lpotter.co.uk>
CC: Luis Chamberlain <mcgrof@...nel.org>, <willy@...radead.org>,
	<josh@...htriplett.org>, Kees Cook <keescook@...omium.org>, Clemens Ladisch
	<clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>, Juergen Gross
	<jgross@...e.com>, Stefano Stabellini <sstabellini@...nel.org>, Oleksandr
	Tyshchenko <oleksandr_tyshchenko@...m.com>, Jiri Slaby
	<jirislaby@...nel.org>, "James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin
 K. Petersen" <martin.petersen@...cle.com>, Doug Gilbert
	<dgilbert@...erlog.com>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Jason
	Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>, Corey Minyard
	<minyard@....org>, Theodore Ts'o <tytso@....edu>, "Jason A. Donenfeld"
	<Jason@...c4.com>, David Ahern <dsahern@...nel.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Robin Holt
	<robinmholt@...il.com>, Steve Wahl <steve.wahl@....com>, Russ Weight
	<russell.h.weight@...el.com>, "Rafael J. Wysocki" <rafael@...nel.org>, Song
	Liu <song@...nel.org>, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang
	<haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
	<decui@...rosoft.com>, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas
	Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi
	<rodrigo.vivi@...el.com>, Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com>,
	David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
	<linux-kernel@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	<linux-serial@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-rdma@...r.kernel.org>,
	<openipmi-developer@...ts.sourceforge.net>, <netdev@...r.kernel.org>,
	<linux-raid@...r.kernel.org>, <linux-hyperv@...r.kernel.org>,
	<intel-gfx@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>, Greg
	Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 01/15] cdrom: Remove now superfluous sentinel element
 from ctl_table array

On Sat, Sep 30, 2023 at 05:52:17PM +0100, Phillip Potter wrote:
> On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote:
> > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote:
> > > > From: Joel Granados <j.granados@...sung.com>
> > > > 
> > > > This commit comes at the tail end of a greater effort to remove the
> > > > empty elements at the end of the ctl_table arrays (sentinels) which
> > > > will reduce the overall build time size of the kernel and run time
> > > > memory bloat by ~64 bytes per sentinel (further information Link :
> > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > > > 
> > > > Remove sentinel element from cdrom_table
> > > > 
> > > > Signed-off-by: Joel Granados <j.granados@...sung.com>
> > > > ---
> > > >  drivers/cdrom/cdrom.c | 3 +--
> > > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> > > > index cc2839805983..451907ade389 100644
> > > > --- a/drivers/cdrom/cdrom.c
> > > > +++ b/drivers/cdrom/cdrom.c
> > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = {
> > > >  		.maxlen		= sizeof(int),
> > > >  		.mode		= 0644,
> > > >  		.proc_handler	= cdrom_sysctl_handler
> > > > -	},
> > > > -	{ }
> > > > +	}
> > > 
> > > You should have the final entry as "}," so as to make any future
> > > additions to the list to only contain that entry, that's long been the
> > > kernel style for lists like this.
> > Will send a V2 with this included. Thx.
> > 
> > > 
> > > So your patches will just remove one line, not 2 and add 1, making it a
> > > smaller diff.
> > indeed.
> > 
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > -- 
> > 
> > Joel Granados
> 
> Hi Joel,
> 
> Thank you for your patch. I look forward to seeing V2, and will be happy
> to review it.
Am following a reported oops. Once I straighten that out, I'll send out
a V2

Bet

> 
> Regards,
> Phil

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)