lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231002185034.1575127-4-anthony.l.nguyen@intel.com> Date: Mon, 2 Oct 2023 11:50:34 -0700 From: Tony Nguyen <anthony.l.nguyen@...el.com> To: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, anthony.l.nguyen@...el.com, Przemek Kitszel <przemyslaw.kitszel@...el.com> Subject: [PATCH net-next 3/3] iavf: Avoid a memory allocation in iavf_print_link_message() From: Christophe JAILLET <christophe.jaillet@...adoo.fr> IAVF_MAX_SPEED_STRLEN is only 13 and 'speed' is allocated and freed within iavf_print_link_message(). 'speed' is only used with some snprintf() and netdev_info() calls. So there is no real use to kzalloc()/free() it. Use the stack instead. This saves a memory allocation. Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com> --- drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c index 8ce6389b5815..980dc69d7fbe 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c +++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c @@ -1389,18 +1389,14 @@ void iavf_disable_vlan_insertion_v2(struct iavf_adapter *adapter, u16 tpid) static void iavf_print_link_message(struct iavf_adapter *adapter) { struct net_device *netdev = adapter->netdev; + char speed[IAVF_MAX_SPEED_STRLEN]; int link_speed_mbps; - char *speed; if (!adapter->link_up) { netdev_info(netdev, "NIC Link is Down\n"); return; } - speed = kzalloc(IAVF_MAX_SPEED_STRLEN, GFP_KERNEL); - if (!speed) - return; - if (ADV_LINK_SUPPORT(adapter)) { link_speed_mbps = adapter->link_speed_mbps; goto print_link_msg; @@ -1452,7 +1448,6 @@ static void iavf_print_link_message(struct iavf_adapter *adapter) } netdev_info(netdev, "NIC Link is Up Speed is %s Full Duplex\n", speed); - kfree(speed); } /** -- 2.38.1
Powered by blists - more mailing lists