netdev - Re: [PATCH net] ipv4: Set offload_failed flag in fibmatch results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRq+xwEzgm8UnzSi@kernel.org>
Date: Mon, 2 Oct 2023 14:59:51 +0200
From: Simon Horman <horms@...nel.org>
To: Benjamin Poirier <bpoirier@...dia.com>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Amit Cohen <amcohen@...dia.com>, Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net] ipv4: Set offload_failed flag in fibmatch results

On Tue, Sep 26, 2023 at 02:27:30PM -0400, Benjamin Poirier wrote:
> Due to a small omission, the offload_failed flag is missing from ipv4
> fibmatch results. Make sure it is set correctly.
> 
> The issue can be witnessed using the following commands:
> echo "1 1" > /sys/bus/netdevsim/new_device
> ip link add dummy1 up type dummy
> ip route add 192.0.2.0/24 dev dummy1
> echo 1 > /sys/kernel/debug/netdevsim/netdevsim1/fib/fail_route_offload
> ip route add 198.51.100.0/24 dev dummy1
> ip route
> 	# 192.168.15.0/24 has rt_trap
> 	# 198.51.100.0/24 has rt_offload_failed
> ip route get 192.168.15.1 fibmatch
> 	# Result has rt_trap
> ip route get 198.51.100.1 fibmatch
> 	# Result differs from the route shown by `ip route`, it is missing
> 	# rt_offload_failed
> ip link del dev dummy1
> echo 1 > /sys/bus/netdevsim/del_device
> 
> Fixes: 36c5100e859d ("IPv4: Add "offload failed" indication to routes")
> Signed-off-by: Benjamin Poirier <bpoirier@...dia.com>
> Reviewed-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>