lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZRv3PgGCa5v0woGh@kernel.org> Date: Tue, 3 Oct 2023 13:13:02 +0200 From: Simon Horman <horms@...nel.org> To: Xin Long <lucien.xin@...il.com> Cc: network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Marcelo Ricardo Leitner <marcelo.leitner@...il.com>, Xufeng Zhang <xufeng.zhang@...driver.com> Subject: Re: [PATCH net] sctp: update hb timer immediately after users change hb_interval On Sun, Oct 01, 2023 at 11:04:20AM -0400, Xin Long wrote: > Currently, when hb_interval is changed by users, it won't take effect > until the next expiry of hb timer. As the default value is 30s, users > have to wait up to 30s to wait its hb_interval update to work. > > This becomes pretty bad in containers where a much smaller value is > usually set on hb_interval. This patch improves it by resetting the > hb timer immediately once the value of hb_interval is updated by users. > > Note that we don't address the already existing 'problem' when sending > a heartbeat 'on demand' if one hb has just been sent(from the timer) > mentioned in: > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg590224.html Hi Xin Long, I wonder if this warrants a fixes tag, and if so, perhaps: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Xin Long <lucien.xin@...il.com> Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists