netdev - Re: [PATCH iwl-net,v2] ice: Fix VF-VF filter rules in switchdev mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202310031925.uHjPXxCu-lkp@intel.com>
Date: Tue, 3 Oct 2023 19:54:09 +0800
From: kernel test robot <lkp@...el.com>
To: Aniruddha Paul <aniruddha.paul@...el.com>,
	intel-wired-lan@...ts.osuosl.org
Cc: oe-kbuild-all@...ts.linux.dev, marcin.szycik@...el.com,
	netdev@...r.kernel.org, Aniruddha Paul <aniruddha.paul@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [PATCH iwl-net,v2] ice: Fix VF-VF filter rules in switchdev mode

Hi Aniruddha,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc4 next-20231003]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Aniruddha-Paul/ice-Fix-VF-VF-filter-rules-in-switchdev-mode/20231003-161801
base:   linus/master
patch link:    https://lore.kernel.org/r/20231003081639.1915967-1-aniruddha.paul%40intel.com
patch subject: [PATCH iwl-net,v2] ice: Fix VF-VF filter rules in switchdev mode
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231003/202310031925.uHjPXxCu-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231003/202310031925.uHjPXxCu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310031925.uHjPXxCu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/intel/ice/ice_tc_lib.c: In function 'ice_eswitch_tc_parse_action':
>> drivers/net/ethernet/intel/ice/ice_tc_lib.c:678:26: warning: unused variable 'repr' [-Wunused-variable]
     678 |         struct ice_repr *repr;
         |                          ^~~~


vim +/repr +678 drivers/net/ethernet/intel/ice/ice_tc_lib.c

   672	
   673	static int ice_eswitch_tc_parse_action(struct net_device *filter_dev,
   674					       struct ice_tc_flower_fltr *fltr,
   675					       struct flow_action_entry *act)
   676	{
   677		int err;
 > 678		struct ice_repr *repr;
   679	
   680		switch (act->id) {
   681		case FLOW_ACTION_DROP:
   682			fltr->action.fltr_act = ICE_DROP_PACKET;
   683			break;
   684	
   685		case FLOW_ACTION_REDIRECT:
   686			err = ice_tc_setup_redirect_action(filter_dev, fltr, act->dev);
   687			if (err)
   688				return err;
   689	
   690			break;
   691	
   692		default:
   693			NL_SET_ERR_MSG_MOD(fltr->extack, "Unsupported action in switchdev mode");
   694			return -EINVAL;
   695		}
   696	
   697		return 0;
   698	}
   699	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki