netdev - Re: [PATCH 2/4] ptp: add ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 2 Oct 2023 17:24:43 -0700
From: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
To: Richard Cochran <richardcochran@...il.com>
Cc: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>, 
	David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Jonathan Corbet <corbet@....net>, Don Hatchett <hatch@...gle.com>, Yuliang Li <yuliangli@...gle.com>, 
	Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCH 2/4] ptp: add ptp_gettimex64any() support

On Sat, Sep 30, 2023 at 2:18 PM Richard Cochran
<richardcochran@...il.com> wrote:
>
> On Thu, Sep 28, 2023 at 07:37:40PM -0700, Mahesh Bandewar wrote:
>
> > diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h
> > index 05cc35fc94ac..1f1e98966cff 100644
> > --- a/include/uapi/linux/ptp_clock.h
> > +++ b/include/uapi/linux/ptp_clock.h
> > @@ -69,6 +69,14 @@
> >   */
> >  #define PTP_PEROUT_V1_VALID_FLAGS    (0)
> >
> > +enum ptp_ts_types {
> > +     PTP_TS_CYCLES = 0,
> > +     PTP_TS_REAL,
> > +     PTP_TS_MONO,
> > +     PTP_TS_RAW,
> > +     PTP_TS_MAX,
> > +};
>
> There is no need for a new set of enumerated values.  Why not use the
> existing clockid_t ?
>
I'm not sure which one you are referring to. These defs need to be
UAPI and the one defined in time.h are not all relevant in this case
(we just need only a few of those) hence the definition. However, if I
missed something, please point me to it.

> Thanks,
> Richard