[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <09dbfd72-0efb-0275-9589-6178c9aca8a1@linux.vnet.ibm.com>
Date: Tue, 3 Oct 2023 17:05:51 -0500
From: Thinh Tran <thinhtr@...ux.vnet.ibm.com>
To: Michael Chan <michael.chan@...adcom.com>
Cc: netdev@...r.kernel.org, siva.kallam@...adcom.com, prashant@...adcom.com,
mchan@...adcom.com, drc@...ux.vnet.ibm.com, pavan.chebbi@...adcom.com,
Venkata Sai Duggi <venkata.sai.duggi@....com>
Subject: Re: [PATCH] net/tg3: fix race condition in tg3_reset_task_cancel()
Thanks for the review.
On 10/3/2023 4:37 AM, Michael Chan wrote:
>
> tg3_flag_set() calls set_bit() which is atomic. The same is true for
> tg3_flag_clear(). Maybe we just need some smp_mb__after_atomic() or
> similar memory barriers.
>
I did not see it being used in this driver. I'll try that.
Thinh Tran
Powered by blists - more mailing lists