netdev - Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRvc3fi1Whe+wnJy@kernel.org>
Date: Tue, 3 Oct 2023 11:20:29 +0200
From: Simon Horman <horms@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
	decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
	paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
	davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, leon@...nel.org,
	longli@...rosoft.com, ssengar@...ux.microsoft.com,
	linux-rdma@...r.kernel.org, daniel@...earbox.net,
	john.fastabend@...il.com, bpf@...r.kernel.org, ast@...nel.org,
	sharmaajay@...rosoft.com, hawk@...nel.org, tglx@...utronix.de,
	shradhagupta@...ux.microsoft.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net,v2, 3/3] net: mana: Fix oversized sge0 for GSO packets

On Fri, Sep 29, 2023 at 01:42:27PM -0700, Haiyang Zhang wrote:
> Handle the case when GSO SKB linear length is too large.
> 
> MANA NIC requires GSO packets to put only the header part to SGE0,
> otherwise the TX queue may stop at the HW level.
> 
> So, use 2 SGEs for the skb linear part which contains more than the
> packet header.
> 
> Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
> v2: coding style updates suggested by Simon Horman

Reviewed-by: Simon Horman <horms@...nel.org>