netdev - Re: [PATCH net] net: microchip: lan743x : bidirectional throughuput improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 4 Oct 2023 13:09:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: Vishvambar Panth S <vishvambarpanth.s@...rochip.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 bryan.whitehead@...rochip.com, UNGLinuxDriver@...rochip.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, andrew@...n.ch
Subject: Re: [PATCH net] net: microchip: lan743x : bidirectional throughuput
 improvement

On Wed, 4 Oct 2023 13:02:17 -0700 Florian Fainelli wrote:
> > Nobody complained for 5 years, and it's not a regression.
> > Let's not treat this as a fix, please repost without the Fixes tag for
> > net-next.  
> 
> As a driver maintainer, you may want to provide some guarantees to your 
> end users/customers that from stable version X.Y.Z the performance 
> issues have been fixed. Performance improvements are definitively border 
> line in terms of being considered as bug fixes though.

I understand that, but too often people just "feel like a device which
advertises X Mbps / Gbps should reach line rate" while no end user
cares.

Luckily stable rules are pretty clear about this (search for
"performance"): 
https://docs.kernel.org/process/stable-kernel-rules.html

As posted it doesn't fulfill the requirements 🤷️