lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20231003231850.work.335-kees@kernel.org> Date: Tue, 3 Oct 2023 16:18:51 -0700 From: Kees Cook <keescook@...omium.org> To: Simon Horman <horms@...nel.org> Cc: Kees Cook <keescook@...omium.org>, Simon Horman <simon.horman@...igine.com>, Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Yinjun Zhang <yinjun.zhang@...igine.com>, Leon Romanovsky <leon@...nel.org>, Yu Xiao <yu.xiao@...igine.com>, Sixiang Chen <sixiang.chen@...igine.com>, oss-drivers@...igine.com, netdev@...r.kernel.org, Louis Peens <louis.peens@...igine.com>, "Gustavo A. R. Silva" <gustavoars@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Tom Rix <trix@...hat.com>, linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org, llvm@...ts.linux.dev Subject: [PATCH] nfp: nsp: Annotate struct nfp_eth_table with __counted_by Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct nfp_eth_table. Cc: Simon Horman <simon.horman@...igine.com> Cc: Jakub Kicinski <kuba@...nel.org> Cc: "David S. Miller" <davem@...emloft.net> Cc: Eric Dumazet <edumazet@...gle.com> Cc: Paolo Abeni <pabeni@...hat.com> Cc: Yinjun Zhang <yinjun.zhang@...igine.com> Cc: Leon Romanovsky <leon@...nel.org> Cc: Yu Xiao <yu.xiao@...igine.com> Cc: Sixiang Chen <sixiang.chen@...igine.com> Cc: oss-drivers@...igine.com Cc: netdev@...r.kernel.org Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci [1] Signed-off-by: Kees Cook <keescook@...omium.org> --- drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h index 6e044ac04917..00264af13b49 100644 --- a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h +++ b/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.h @@ -241,7 +241,7 @@ struct nfp_eth_table { u64 link_modes_supp[2]; u64 link_modes_ad[2]; - } ports[]; + } ports[] __counted_by(count); }; struct nfp_eth_table *nfp_eth_read_ports(struct nfp_cpp *cpp); -- 2.34.1
Powered by blists - more mailing lists