netdev - Bug in 6.5 tar-ball

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGt4E5uB_zX-3OtUcTRPjYiiJ1FYbYAdr6uWSgy1qJip5p7wnQ@mail.gmail.com>
Date: Wed, 4 Oct 2023 14:27:56 -0700
From: Markus Mayer <mmayer@...adcom.com>
To: netdev@...r.kernel.org
Subject: Bug in 6.5 tar-ball

Hi,

It would seem I discovered an issue with the ethtool-6.5 tar-balls on
cdn.kernel.org. They are missing the const.h header file. Maybe other
files too.

Please verify as follows:

$ curl -s -o - https://cdn.kernel.org/pub/software/network/ethtool/ethtool-6.5.tar.xz
| \
    tar tJf - | grep const
[no output]

$ curl -s -o - https://cdn.kernel.org/pub/software/network/ethtool/ethtool-6.5.tar.gz
| \
    tar tzf - | grep const
[no output]

Meanwhile, this tar-ball seems correct:

$ curl -s -o - https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/snapshot/ethtool-6.5.tar.gz
| \
    tar tzf - | grep const
ethtool-6.5/uapi/linux/const.h

So, the tar-ball directly taken from git.kernel.org does have const.h,
but the two from cdn.kernel.org do not.

This is currently leading to build problems for me.

/storage/buildroot/output/arm64/host/bin/aarch64-linux-gcc
-DHAVE_CONFIG_H -I.  -I./uapi  -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wall -Wextra
-D_POSIX_C_SOURCE=200809L -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
-D_FILE_OFFSET_BITS=64  -Os -g0 -D_FORTIFY_SOURCE=2 -std=gnu11 -c -o
netlink/rings.o netlink/rings.c
In file included from internal.h:45,
                 from common.c:7:
./uapi/linux/ethtool.h:1507:19: warning: implicit declaration of
function '__KERNEL_DIV_ROUND_UP' [-Wimplicit-function-declaration]
  __u32 queue_mask[__KERNEL_DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
                   ^~~~~~~~~~~~~~~~~~~~~
./uapi/linux/ethtool.h:1507:8: error: variably modified 'queue_mask'
at file scope
  __u32 queue_mask[__KERNEL_DIV_ROUND_UP(MAX_NUM_QUEUE, 32)];
        ^~~~~~~~~~
make[3]: *** [Makefile:1410: common.o] Error 1
make[3]: *** Waiting for unfinished jobs....

There are, of course, ways to work around it, but the tar-balls should
be fixed, since I won't be the only one hitting this problem.

Regards,
-Markus