netdev - Re: [PATCH] idpf: fix building without IPv4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 3 Oct 2023 15:43:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>, "Lobakin, Alexandr"
 <alexandr.lobakin@...el.com>, Arnd Bergmann <arnd@...db.de>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Paolo
 Abeni" <pabeni@...hat.com>, Alan Brady <alan.brady@...el.com>, "Sridhar
 Samudrala" <sridhar.samudrala@...el.com>, Willem de Bruijn
 <willemb@...gle.com>, Phani Burra <phani.r.burra@...el.com>, Joshua Hay
 <joshua.a.hay@...el.com>, Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
 Madhu Chittim <madhu.chittim@...el.com>,
 <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, Alexander Lobakin
 <aleksander.lobakin@...el.com>
Subject: Re: [PATCH] idpf: fix building without IPv4

On Mon, 25 Sep 2023 10:05:03 -0700 Tony Nguyen wrote:
> Also, a pending patch for this [1], however, this does look a bit more 
> efficient. Adding Olek as he's author on the other patch.
> 
> netdev maintainers,
> 
> If this is the version that does get picked up, did you want to take it 
> directly to close out the compile issues?

Sorry for the delays. Should we not add a !INET static inline wrapper
for tcp_gro_complete()? Seems a bit backwards to me to make drivers
suffer and think about such a preposterous config :S

$ git grep tcp_gro_complete -- drivers/
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:        tcp_gro_complete(skb);
drivers/net/ethernet/broadcom/bnxt/bnxt.c:              tcp_gro_complete(skb);
drivers/net/ethernet/intel/idpf/idpf_txrx.c:    tcp_gro_complete(skb);
drivers/net/ethernet/qlogic/qede/qede_fp.c:     tcp_gro_complete(skb);

We have 4 drivers which need ifdefs already and the number will only
grow with GRO-HW spreading.