netdev - Re: [PATCH net] ice: don't stop netdev tx queues when setting up XSK socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231003154920.6ae3801f@kernel.org>
Date: Tue, 3 Oct 2023 15:49:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
 netdev@...r.kernel.org, Kamil Maziarz <kamil.maziarz@...el.com>,
 maciej.fijalkowski@...el.com, magnus.karlsson@...el.com, ast@...nel.org,
 daniel@...earbox.net, hawk@...nel.org, john.fastabend@...il.com,
 bpf@...r.kernel.org, Chandan Kumar Rout <chandanx.rout@...el.com>
Subject: Re: [PATCH net] ice: don't stop netdev tx queues when setting up
 XSK socket

On Mon, 25 Sep 2023 10:19:57 -0700 Tony Nguyen wrote:
> Avoid stopping netdev tx queues during XSK setup by removing
> netif_tx_stop_queue() and netif_tx_start_queue().
> These changes prevent unnecessary stopping and starting of netdev
> transmit queues during the setup of XDP socket. Without this change,
> after stopping the XDP traffic flow tracker and then stopping
> the XDP prog - NETDEV WATCHDOG transmit queue timed out appears.

I think we need more info about what happens here.

Maybe ice_qp_ena() fails before it gets to the start?
If we don't understand what happens, exactly, we may be papering
over other bugs.
-- 
pw-bot: cr