netdev - Re: [PATCHv2 next 1/3] ptp: add ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZRzsWOODyFYIxXhn@hoboy.vegasvil.org>
Date: Tue, 3 Oct 2023 21:38:48 -0700
From: Richard Cochran <richardcochran@...il.com>
To: Mahesh Bandewar <maheshb@...gle.com>
Cc: Netdev <netdev@...r.kernel.org>, Linux <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, John Stultz <jstultz@...gle.com>,
	Don Hatchett <hatch@...gle.com>, Yuliang Li <yuliangli@...gle.com>,
	Mahesh Bandewar <mahesh@...dewar.net>
Subject: Re: [PATCHv2 next 1/3] ptp: add ptp_gettimex64any() support

On Mon, Oct 02, 2023 at 09:17:01PM -0700, Mahesh Bandewar wrote:
> add support for TS sandwich of the user preferred timebase. The options
> supported are PTP_TS_REAL (CLOCK_REALTIME), PTP_TS_MONO (CLOCK_MONOTONIC),
> and PTP_TS_RAW (CLOCK_MONOTONIC_RAW)
> 
> Option of PTP_TS_REAL is equivalent of using ptp_gettimex64().

This change log is horrible.

Please write a proper explanation, and be sure to cover the following
three points.

1. context
2. problem
3. solution

Every change log must have those three items.

In addition, this series needs a cover letter that clearly justifies
the need for this change.

Thanks,
Richard