lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231004161651.76f686f3@kernel.org> Date: Wed, 4 Oct 2023 16:16:51 -0700 From: Jakub Kicinski <kuba@...nel.org> To: <edward.cree@....com> Cc: <linux-net-drivers@....com>, <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>, Edward Cree <ecree.xilinx@...il.com>, <netdev@...r.kernel.org>, <habetsm.xilinx@...il.com>, <sudheer.mogilappagari@...el.com>, <jdamato@...tly.com>, <andrew@...n.ch>, <mw@...ihalf.com>, <linux@...linux.org.uk>, <sgoutham@...vell.com>, <gakula@...vell.com>, <sbhatta@...vell.com>, <hkelam@...vell.com>, <saeedm@...dia.com>, <leon@...nel.org> Subject: Re: [PATCH v4 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts On Wed, 27 Sep 2023 19:13:37 +0100 edward.cree@....com wrote: > While this is not needed to serialise the ethtool entry points (which > are all under RTNL), drivers may have cause to asynchronously access > dev->ethtool->rss_ctx; taking dev->ethtool->rss_lock allows them to > do this safely without needing to take the RTNL. Can we use a replay mechanism, like we do in TC offloads and VxLAN/UDP ports? The driver which lost config can ask for the rss contexts to be "replayed" and the core will issue a series of ->create calls for all existing entries? Regarding the lock itself - can we hide it under ethtool_rss_lock(dev) / ethtool_rss_unlock(dev) helpers?
Powered by blists - more mailing lists