netdev - RE: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power override

Open Source and information security mailing list archives

Date: Thu, 5 Oct 2023 13:58:17 +0000
From: "Drewek, Wojciech" <wojciech.drewek@...el.com>
To: Ido Schimmel <idosch@...sch.org>
CC: Jakub Kicinski <kuba@...nel.org>, "idosch@...dia.com" <idosch@...dia.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power
 override

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Ido
> Schimmel
> Sent: Thursday, September 21, 2023 2:09 PM
> To: Drewek, Wojciech <wojciech.drewek@...el.com>
> Cc: Jakub Kicinski <kuba@...nel.org>; idosch@...dia.com; intel-wired-
> lan@...ts.osuosl.org; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>;
> netdev@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power
> override
> 
> On Fri, Sep 15, 2023 at 01:15:01PM +0000, Drewek, Wojciech wrote:
> > In ice driver port split works per device not per port. According to
> > /Documentation/networking/devlink/ice.rst, section "Port split":
> > 	The "ice" driver supports port splitting only for port 0, as the FW has
> > 	a predefined set of available port split options for the whole device.
> > And if you look at available port options (same file) you'll see that in case of
> "Split count" 1
> > only quad 1 is working. And in case of "Split count" 2 the second quad might
> be used. So, if we
> > increase max_pwr in the first quad in case of "Split count" 1 and then switch
> to "Split count" 2,
> > the second quad might end up with no link (because it will have decreased
> max_pwr).
> 
> But there's also an option where the second cage isn't actually used.
> Anyway, my suggestion is to allow user space to set / get the max power
> using ethtool and give user space visibility about link down reason via
> the ethtool extended state.

Thanks for discussion Ido, we will follow your suggestion.

> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives